Skip to content

[18.0][MIG] fieldservice_survey: Migration to 18.0 #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] fieldservice_survey: Migration to 18.0 #1423

wants to merge 6 commits into from

Conversation

TB-Ph35
Copy link

@TB-Ph35 TB-Ph35 commented Jul 17, 2025

No description provided.

ivantodorovich
ivantodorovich requested changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration fieldservice_survey

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Aug 18, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 18, 2025
Open
33 tasks
@TB-Ph35 TB-Ph35 force-pushed the 18.0-mig-fieldservice_survey branch from 9098d48 to eec57ba Compare August 29, 2025 21:19
@TB-Ph35
Copy link
Author

TB-Ph35 commented Aug 29, 2025

Fix have been made.
But someone tell me that in the mail there were no url for the survey. I couldn't fix why. If someone have en idea.

ivantodorovich
ivantodorovich reviewed Sep 1, 2025
View reviewed changes
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you squash your FIX comments and '_' commit with the [MIG] fieldservice_survey: Migration to 18.0 one?
They are part of the same thing

fieldservice_survey/data/mail_data.xml
</p>
</div>
</field>
<!-- <field name="report_name">${(object.name or '').replace('/','_')}</field> -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with this?
Pending TODO?

@ivantodorovich
Copy link
Contributor

But someone tell me that in the mail there were no url for the survey. I couldn't fix why. If someone have en idea.

What do you mean?
Can you show with an example?

@TB-Ph35
Copy link
Author

TB-Ph35 commented Sep 15, 2025

image

When generate e-mail form the field_services order, the pink button isn't click-able. there is not link.
But if I take the same survey in the survey menu and send e-mail, the link is there.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich requested changes

Assignees
No one assigned
Labels
needs fixing needs review
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@TB-Ph35 @ivantodorovich @OCA-git-bot @kaynnan @mymage