Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] account_operating_unit #596

Closed

Conversation

BT-aleonard
Copy link
Contributor

@BT-aleonard BT-aleonard commented Jun 13, 2023

Includes PRs:
#616
#610

sudhir-serpentcs and others added 30 commits May 11, 2023 08:22
…f setting an inter-OU accounts triggers from other modules when creating companies
* Add management of payments using operating units
* Trial Balance by operating units
* Improve tests
@AaronHForgeFlow
Copy link
Contributor

/ocabot migration account_operating_unit

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 13, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 13, 2023
9 tasks
@BT-aleonard BT-aleonard force-pushed the 16.0-mig-account_operating_unit branch from 2a597f3 to aa19afb Compare June 22, 2023 10:33
@BT-aleonard
Copy link
Contributor Author

@AaronHForgeFlow can you review this PR, please?

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall works ok. Just would like to attend some comments

account_operating_unit/views/account_move_view.xml Outdated Show resolved Hide resolved
account_operating_unit/views/account_move_view.xml Outdated Show resolved Hide resolved
<field name="inherit_id" ref="account.view_account_journal_form" />
<field name="arch" type="xml">
<field name="company_id" position="after">
<field
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see this field in journals in runbot. Can you check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the normal company_id field.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the field appears twice on the form definition, first globally and invisible, second with a groups restriction, and we want to use the second one. I suggest changing the anchor point for the extension (see suggested change), as I'm not sure it's legit to have an anchor on a field which is group-restricted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this fix:
image

@AaronHForgeFlow
Copy link
Contributor

Can you please include this? #616

<field name="inherit_id" ref="account.view_account_journal_form" />
<field name="arch" type="xml">
<field name="company_id" position="after">
<field
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the field appears twice on the form definition, first globally and invisible, second with a groups restriction, and we want to use the second one. I suggest changing the anchor point for the extension (see suggested change), as I'm not sure it's legit to have an anchor on a field which is group-restricted.

account_operating_unit/views/account_journal_view.xml Outdated Show resolved Hide resolved
<field name="inherit_id" ref="account.view_account_journal_form" />
<field name="arch" type="xml">
<field name="company_id" position="after">
<field
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this fix:
image

@AaronHForgeFlow
Copy link
Contributor

Can you include this? #610 Thanks in advance!.

account_operating_unit/models/account_move.py Outdated Show resolved Hide resolved
account_operating_unit/models/account_move.py Outdated Show resolved Hide resolved
account_operating_unit/models/account_move.py Outdated Show resolved Hide resolved
@raulovallet
Copy link

Will this continue?, I've tried installing this and does't work :(

@AaronHForgeFlow
Copy link
Contributor

@raulovallet If you fixed it you can create a new PR as this one seems stale

@whulshof
Copy link

In account_move_view there is still a reference to account_analytic_id, whereas that field is not in account_move_line anymore

@hbrunn
Copy link
Member

hbrunn commented Mar 14, 2024

I propose to supersede this with #656

@AaronHForgeFlow
Copy link
Contributor

Superseded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.