[18.0][MIG] purchase_warn_option: Migration 18.0

[sabrinaRMartin]

Migration from version 15.0 to 18.0

This module depends on PR:

• base_warn_option

@moduon @Shide MT-13047

https://www.loom.com/share/2425212b1eaf4fd7955c72c468ef791f

[Andrii9090]

@sabrinaRMartin good job! Code&funcional review 👍

Test for partner:

Test for product:

[BhaveshHeliconia]

Functional review LGTM!

[Shide]

Code review

[Gelojr]

Congratulations on the work done @sabrinaRMartin. However, I think a review is necessary.
I have performed the following functional tests.

• Test 1: OK — Partner warning option (Warning) correctly fills and saves the warning message from the selected Warn Option.
• Test 2: OK — Partner warning option (Block) correctly fills and saves the blocking message from the selected Warn Option.
• Test 3: NOT OK — Changing the Partner warning type after selecting a Warn Option keeps the previous message content and saves an inconsistent configuration.

Reproduction steps for Test 3 (NOT OK):

1. Create two Warn Options for partner purchase warnings: one with allowed warning type = Warning, and another with allowed warning type = Block.

2. Go to a Vendor (Partner) and set “Warning on the Purchase Order” = Warning.
3. Select the Warn Option of type Warning and confirm the message fields are filled with the Warning content.
4. Change “Warning on the Purchase Order” from Warning to Blocking Message.
5. Observe that the message fields below are not updated and still show the previous Warning content.

6. Save the vendor.

Observed behavior: The vendor ends up with “Blocking Message” selected, but the stored message text remains the one from the Warning-type option (inconsistent: Block type with Warning content).

Expected behavior: When switching the warning type (Warning ↔ Block), the message should be cleared or updated to match a Warn Option compatible with the new type, preventing saving a mismatched configuration.

[Shide]

Congratulations on the work done @sabrinaRMartin. However, I think a review is necessary. I have performed the following functional tests.

• Test 1: OK — Partner warning option (Warning) correctly fills and saves the warning message from the selected Warn Option.
• Test 2: OK — Partner warning option (Block) correctly fills and saves the blocking message from the selected Warn Option.
• Test 3: NOT OK — Changing the Partner warning type after selecting a Warn Option keeps the previous message content and saves an inconsistent configuration.

Reproduction steps for Test 3 (NOT OK):

1. Create two Warn Options for partner purchase warnings: one with allowed warning type = Warning, and another with allowed warning type = Block.

2. Go to a Vendor (Partner) and set “Warning on the Purchase Order” = Warning. 3. Select the Warn Option of type Warning and confirm the message fields are filled with the Warning content. 4. Change “Warning on the Purchase Order” from Warning to Blocking Message. 5. Observe that the message fields below are not updated and still show the previous Warning content. 6. Save the vendor.

Observed behavior: The vendor ends up with “Blocking Message” selected, but the stored message text remains the one from the Warning-type option (inconsistent: Block type with Warning content).

Expected behavior: When switching the warning type (Warning ↔ Block), the message should be cleared or updated to match a Warn Option compatible with the new type, preventing saving a mismatched configuration.

Not removing the message is intended.
This module only copies the text to the field that shows warning/blocks.
This review should be OK

[Gelojr]

Congratulations on the great work.
I have performed the following functional tests.

• Test 1: OK — Vendor: selecting a Warning-type Warn Option correctly fills the purchase warning message.
• Test 2: OK — Vendor: selecting a Block-type Warn Option correctly fills the blocking message.
• Test 3: OK — Vendor: the Warn Option selector is constrained by the selected warning type (it only allows Warning options when “Warning” is selected, and only Block options when “Blocking Message” is selected; it does not allow selecting a Warning message while “Blocking Message” is set, nor the other way around, and it also excludes product-specific options).
• Test 4: OK — Product: selecting a Warning-type Warn Option correctly fills the purchase line warning message.
• Test 5: OK — Product: generic Warn Options (no specific type) can be selected and are applied correctly.
• Test 6: OK — When warning is set to no-message, the Warn Option selector is hidden.
• Test 7: OK — Purchase Order: vendor warnings/blocks use the message coming from the selected Warn Option.
• Test 8: OK — Purchase Order: product warnings use the message coming from the selected Warn Option.

[rafaelbn]

/ocabot migration purchase_warn_option

[rafaelbn]

Functional review

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-2921-by-rafaelbn-bump-patch, awaiting test results.

[OCA-git-bot]

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-2921-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[rafaelbn]

/ocabot merge patch

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-2921-by-rafaelbn-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 4134b7e. Thanks a lot for contributing to OCA. ❤️