[18.0][MIG] sale_start_end_dates #3505
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace openerp by odoo in import declarations
Currently translated at 100,0% (16 of 16 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_start_end_dates/nl_NL/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Convert readme to new subdir format
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_start_end_dates/
Currently translated at 26.7% (4 of 15 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_start_end_dates/pt/
Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/es/
Currently translated at 71.4% (10 of 14 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/
Currently translated at 53.3% (8 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/
Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/es/
Currently translated at 66.6% (10 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/
Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/
Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_start_end_dates/it/
In tests: use setUpClass(cls), stop using demo data and several code cleanup
Inherit standalone sale.order.line views
alexis-via
force-pushed
the
18-mig-sale_start_end_dates
branch
from
4492c86 to
8bd210b
Compare
Member
|
@alexis-via I take the opportunity to remind this demand from @sbidoul to move the account_invoice_start_end_dates dependency to LGPL OCA/account-closing#300 which IMHO would be a great move for such a small utility module. My personal opinion on this is:
|
Contributor
|
/ocabot migration sale_start_end_dates |
| { | ||
| "name": "Sale Start End Dates", | ||
| "version": "17.0.1.0.0", | ||
| "version": "18.0.1.0.0", |
Contributor
There was a problem hiding this comment.
@alexis-via Could you put this change in migration commit ? Thanks
fabian-digital
approved these changes
Aug 27, 2025
chaule97
reviewed
Nov 7, 2025
| and order.default_start_date > order.default_end_date | ||
| ): | ||
| raise ValidationError( | ||
| _( |
Contributor
There was a problem hiding this comment.
Suggested change
| _( | |
| self.env._( |
| res = {"warning": {}} | ||
| for line in self: | ||
| if line.number_of_days < 0: | ||
| res["warning"]["title"] = _("Wrong number of days") |
Contributor
There was a problem hiding this comment.
Suggested change
| res["warning"]["title"] = _("Wrong number of days") | |
| res["warning"]["title"] = self.env._("Wrong number of days") |
| for line in self: | ||
| if line.number_of_days < 0: | ||
| res["warning"]["title"] = _("Wrong number of days") | ||
| res["warning"]["message"] = _( |
Contributor
There was a problem hiding this comment.
Suggested change
| res["warning"]["message"] = _( | |
| res["warning"]["message"] = self.env._( |
Comment on lines
+123
to
+124
| _("Missing End Date for sale order line with Product '%s'.") | ||
| % (line.product_id.display_name) |
Contributor
There was a problem hiding this comment.
Suggested change
| _("Missing End Date for sale order line with Product '%s'.") | |
| % (line.product_id.display_name) | |
| self.env._("Missing End Date for sale order line with Product '%s'.", line.product_id.display_name) |
Comment on lines
+128
to
+132
| _( | ||
| "Missing Start Date for sale order line with " | ||
| "Product '%s'." | ||
| ) | ||
| % (line.product_id.display_name) |
Contributor
There was a problem hiding this comment.
Suggested change
| _( | |
| "Missing Start Date for sale order line with " | |
| "Product '%s'." | |
| ) | |
| % (line.product_id.display_name) | |
| self.env._( | |
| "Missing Start Date for sale order line with " | |
| "Product '%s'.", | |
| line.product_id.display_name | |
| ) |
| ) | ||
| if line.start_date > line.end_date: | ||
| raise ValidationError( | ||
| _( |
Contributor
There was a problem hiding this comment.
Suggested change
| _( | |
| self.env._( |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from v17 to v18
Add fields in sale.report (improvement made in a separate commit)