-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[18.0][MIG] sale_start_end_dates #3505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexis-via
wants to merge
52
commits into
OCA:18.0
Choose a base branch
from
akretion:18-mig-sale_start_end_dates
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 50 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
8dabcd5
Initial check-in of the rental project.
839ec22
Port to v8 and new API with several enhancements
911747c
Slovene translations added
sysadminmatmoz 2f8d127
OCA Transbot updated translations from Transifex
oca-transbot b99c46a
Port sale_start_end_dates and sale_rental (#353)
77b01de
sale_start_end_dates and sale_rental
dvdhinesh 1eb31e6
Product qty on rental pickings
alexis-via e001dac
Update sale_start_end_dates.pot
oca-travis 54cb673
Translated using Weblate (Nederlands (nl_NL))
thomaspot b9b6bd8
sale_start_end_dates: Migration to 11.0.
murtuzasaleh b9e799d
Update sale_start_end_dates.pot
oca-travis eaf280c
Update translation files
oca-transbot 828244a
[MIG] sale_start_end_dates and sale_rental to v12
alexis-via b83dd75
[FIX] sale_start_end_dates: bad code in compute method
alexis-via a0d6e8c
[UPD] Update sale_start_end_dates.pot
oca-travis 88f2bb7
[UPD] README.rst
OCA-git-bot 0acedde
Update translation files
oca-transbot 9dfcdeb
Translated using Weblate (Portuguese)
pedrocs-exo 6d134b5
[MIG] sale_start_end_dates to v13
alexis-via 3b375c7
Black/flake8 fight
alexis-via 6597a20
Add maintainers key in manifest
alexis-via 1df07fb
[MIG] sale_start_end_dates to v14
alexis-via 88486bb
[UPD] Update sale_start_end_dates.pot
oca-travis 303dfe5
[UPD] README.rst
OCA-git-bot a0c4b6e
[MIG] sale_start_end_dates to v15
alexis-via 347677b
[UPD] Update sale_start_end_dates.pot
df32b3d
[UPD] README.rst
OCA-git-bot 3cf3289
sale_start_end_dates 15.0.1.0.1
OCA-git-bot 983534f
[UPD] README.rst
OCA-git-bot 74ca8c9
[UPD] README.rst
OCA-git-bot 705598a
[MIG] sale_start_end_dates: Migration to 16.0
vancouver29 becce5a
sale_start_end_dates: onchange -> compute methods
alexis-via 34f0443
Fix Singleton Exception (#29)
agent-z28 4e75ffd
[UPD] Update sale_start_end_dates.pot
5d73b00
[UPD] README.rst
OCA-git-bot 586e923
sale_start_end_dates 16.0.1.0.1
OCA-git-bot 51bfae1
Translated using Weblate (Spanish)
Ivorra78 82e47f7
[UPD] README.rst
OCA-git-bot 18141be
Translated using Weblate (Italian)
francesco-ooops 955cf2e
Update translation files
weblate 60b0d3a
Translated using Weblate (Italian)
francesco-ooops 92bbd1c
Translated using Weblate (Spanish)
Ivorra78 63af9bd
Translated using Weblate (Italian)
mymage 4749ae4
Translated using Weblate (Italian)
mymage bbd118e
Translated using Weblate (Italian)
mymage 21d9298
[IMP] sale_start_end_dates: pre-commit auto fixes
alexis-via b1a8e8b
[MIG] sale_start_end_dates: migrate to v17
alexis-via 1121604
[UPD] Update sale_start_end_dates.pot
15412fa
[BOT] post-merge updates
OCA-git-bot b961750
[IMP] sale_start_end_dates: pre-commit auto fixes
alexis-via 8e14ccf
[MIG] sale_start_end_dates to v18
alexis-via 8bd210b
[IMP] sale_start_end_dates: add fields in sale.report
alexis-via File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| ==================== | ||
| Sale Start End Dates | ||
| ==================== | ||
|
|
||
| .. | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! This file is generated by oca-gen-addon-readme !! | ||
| !! changes will be overwritten. !! | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! source digest: sha256:00f45fdd23400a61c07c608305731b37a68342eaafdd8cb6d13a5991093b31f6 | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
|
|
||
| .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png | ||
| :target: https://odoo-community.org/page/development-status | ||
| :alt: Beta | ||
| .. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png | ||
| :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
| :alt: License: AGPL-3 | ||
| .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github | ||
| :target: https://github.com/OCA/sale-workflow/tree/18.0/sale_start_end_dates | ||
| :alt: OCA/sale-workflow | ||
| .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png | ||
| :target: https://translation.odoo-community.org/projects/sale-workflow-18-0/sale-workflow-18-0-sale_start_end_dates | ||
| :alt: Translate me on Weblate | ||
| .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png | ||
| :target: https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&target_branch=18.0 | ||
| :alt: Try me on Runboat | ||
|
|
||
| |badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
|
||
| This module adds the fields *Start Date* and *End Date* on sale order | ||
| lines (requied fields when the product has the *Must Have Start and End | ||
| Dates* property). You can also define a *Default Start Date* and | ||
| *Default End Date* on the sale order; when set, these dates will be used | ||
| by default on new sale order lines. Upon invoice creation, the values of | ||
| the start/end dates of the sale order line are copied to the start/end | ||
| dates of invoice lines. | ||
|
|
||
| This module is a technical module: it is designed to be used with other | ||
| modules such as the *sale_rental* module. | ||
|
|
||
| **Table of contents** | ||
|
|
||
| .. contents:: | ||
| :local: | ||
|
|
||
| Bug Tracker | ||
| =========== | ||
|
|
||
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/sale-workflow/issues>`_. | ||
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us to smash it by providing a detailed and welcomed | ||
| `feedback <https://github.com/OCA/sale-workflow/issues/new?body=module:%20sale_start_end_dates%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | ||
|
|
||
| Do not contact contributors directly about support or help with technical issues. | ||
|
|
||
| Credits | ||
| ======= | ||
|
|
||
| Authors | ||
| ------- | ||
|
|
||
| * Akretion | ||
| * Sodexis | ||
|
|
||
| Contributors | ||
| ------------ | ||
|
|
||
| - Alexis de Lattre <[email protected]> | ||
| - Sodexis <[email protected]> | ||
| - Serpent Consulting Services Pvt. Ltd. <[email protected]> | ||
|
|
||
| Maintainers | ||
| ----------- | ||
|
|
||
| This module is maintained by the OCA. | ||
|
|
||
| .. image:: https://odoo-community.org/logo.png | ||
| :alt: Odoo Community Association | ||
| :target: https://odoo-community.org | ||
|
|
||
| OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
| mission is to support the collaborative development of Odoo features and | ||
| promote its widespread use. | ||
|
|
||
| .. |maintainer-alexis-via| image:: https://github.com/alexis-via.png?size=40px | ||
| :target: https://github.com/alexis-via | ||
| :alt: alexis-via | ||
|
|
||
| Current `maintainer <https://odoo-community.org/page/maintainer-role>`__: | ||
|
|
||
| |maintainer-alexis-via| | ||
|
|
||
| This module is part of the `OCA/sale-workflow <https://github.com/OCA/sale-workflow/tree/18.0/sale_start_end_dates>`_ project on GitHub. | ||
|
|
||
| You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| from . import models |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Copyright 2014-2021 Akretion France (http://www.akretion.com) | ||
| # @author Alexis de Lattre <[email protected]> | ||
| # Copyright 2016-2019 Sodexis (http://sodexis.com) | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| { | ||
| "name": "Sale Start End Dates", | ||
| "version": "18.0.1.0.0", | ||
| "category": "Sales", | ||
| "license": "AGPL-3", | ||
| "summary": "Adds start date and end date on sale order lines", | ||
| "author": "Akretion, Sodexis, Odoo Community Association (OCA)", | ||
| "maintainers": ["alexis-via"], | ||
| "website": "https://github.com/OCA/sale-workflow", | ||
| "depends": ["account_invoice_start_end_dates", "sale"], | ||
| "data": ["views/sale_order.xml"], | ||
| "installable": True, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| # Translation of Odoo Server. | ||
| # This file contains the translation of the following modules: | ||
| # * sale_start_end_dates | ||
| # | ||
| # Translators: | ||
| # OCA Transbot <[email protected]>, 2017 | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: Odoo Server 10.0\n" | ||
| "Report-Msgid-Bugs-To: \n" | ||
| "POT-Creation-Date: 2017-05-17 02:40+0000\n" | ||
| "PO-Revision-Date: 2017-05-17 02:40+0000\n" | ||
| "Last-Translator: OCA Transbot <[email protected]>, 2017\n" | ||
| "Language-Team: Catalan (https://www.transifex.com/oca/teams/23907/ca/)\n" | ||
| "Language: ca\n" | ||
| "MIME-Version: 1.0\n" | ||
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: \n" | ||
| "Plural-Forms: nplurals=2; plural=(n != 1);\n" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model.fields,field_description:sale_start_end_dates.field_sale_order__default_end_date | ||
| msgid "Default End Date" | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model.fields,field_description:sale_start_end_dates.field_sale_order__default_start_date | ||
| msgid "Default Start Date" | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #. odoo-python | ||
| #: code:addons/sale_start_end_dates/models/sale_order.py:0 | ||
| #, python-format | ||
| msgid "" | ||
| "Default Start Date (%(start_date)s) should be before or be the same as " | ||
| "Default End Date (%(end_date)s) for sale order '%(name)s'." | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model.fields,field_description:sale_start_end_dates.field_sale_order_line__end_date | ||
| msgid "End Date" | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model.fields,help:sale_start_end_dates.field_sale_order_line__must_have_dates | ||
| msgid "" | ||
| "If this option is active, the user will have to enter a Start Date and an " | ||
| "End Date on the invoice lines that have this product." | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #. odoo-python | ||
| #: code:addons/sale_start_end_dates/models/sale_order.py:0 | ||
| #, python-format | ||
| msgid "Missing End Date for sale order line with Product '%s'." | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #. odoo-python | ||
| #: code:addons/sale_start_end_dates/models/sale_order.py:0 | ||
| #, python-format | ||
| msgid "Missing Start Date for sale order line with Product '%s'." | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model.fields,field_description:sale_start_end_dates.field_sale_order_line__must_have_dates | ||
| msgid "Must Have Start/End Dates" | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model.fields,field_description:sale_start_end_dates.field_sale_order_line__number_of_days | ||
| msgid "Number of Days" | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #. odoo-python | ||
| #: code:addons/sale_start_end_dates/models/sale_order.py:0 | ||
| #, python-format | ||
| msgid "" | ||
| "On sale order line with product '%(product_name)s', the number of days is " | ||
| "negative (%(number_of_days)s) ; this is not allowed. The number of days has " | ||
| "been forced to 1." | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model,name:sale_start_end_dates.model_sale_order | ||
| msgid "Sales Order" | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model,name:sale_start_end_dates.model_sale_order_line | ||
| msgid "Sales Order Line" | ||
| msgstr "Línia de comanda de vendes" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model.fields,field_description:sale_start_end_dates.field_sale_order_line__start_date | ||
| msgid "Start Date" | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #. odoo-python | ||
| #: code:addons/sale_start_end_dates/models/sale_order.py:0 | ||
| #, python-format | ||
| msgid "" | ||
| "Start Date (%(start_date)s) should be before or be the same as End Date " | ||
| "(%(end_date)s) for sale order line with Product '%(product_name)s'." | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #. odoo-python | ||
| #: code:addons/sale_start_end_dates/models/sale_order.py:0 | ||
| #, python-format | ||
| msgid "Wrong number of days" | ||
| msgstr "" | ||
|
|
||
| #, fuzzy | ||
| #~| msgid "Sales Order" | ||
| #~ msgid "Sale Order" | ||
| #~ msgstr "Comandes de venda" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| # Translation of Odoo Server. | ||
| # This file contains the translation of the following modules: | ||
| # * sale_start_end_dates | ||
| # | ||
| # Translators: | ||
| # OCA Transbot <[email protected]>, 2017 | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: Odoo Server 10.0\n" | ||
| "Report-Msgid-Bugs-To: \n" | ||
| "POT-Creation-Date: 2017-05-17 02:40+0000\n" | ||
| "PO-Revision-Date: 2017-05-17 02:40+0000\n" | ||
| "Last-Translator: OCA Transbot <[email protected]>, 2017\n" | ||
| "Language-Team: German (https://www.transifex.com/oca/teams/23907/de/)\n" | ||
| "Language: de\n" | ||
| "MIME-Version: 1.0\n" | ||
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: \n" | ||
| "Plural-Forms: nplurals=2; plural=(n != 1);\n" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model.fields,field_description:sale_start_end_dates.field_sale_order__default_end_date | ||
| msgid "Default End Date" | ||
| msgstr "Vorgabe-Enddatum" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model.fields,field_description:sale_start_end_dates.field_sale_order__default_start_date | ||
| msgid "Default Start Date" | ||
| msgstr "Vorgabe-Anfangsdatum" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #. odoo-python | ||
| #: code:addons/sale_start_end_dates/models/sale_order.py:0 | ||
| #, python-format | ||
| msgid "" | ||
| "Default Start Date (%(start_date)s) should be before or be the same as " | ||
| "Default End Date (%(end_date)s) for sale order '%(name)s'." | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model.fields,field_description:sale_start_end_dates.field_sale_order_line__end_date | ||
| msgid "End Date" | ||
| msgstr "Enddatum" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model.fields,help:sale_start_end_dates.field_sale_order_line__must_have_dates | ||
| msgid "" | ||
| "If this option is active, the user will have to enter a Start Date and an " | ||
| "End Date on the invoice lines that have this product." | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #. odoo-python | ||
| #: code:addons/sale_start_end_dates/models/sale_order.py:0 | ||
| #, python-format | ||
| msgid "Missing End Date for sale order line with Product '%s'." | ||
| msgstr "Fehlendes Enddatum in Auftragsposition des Produkts '%s'." | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #. odoo-python | ||
| #: code:addons/sale_start_end_dates/models/sale_order.py:0 | ||
| #, python-format | ||
| msgid "Missing Start Date for sale order line with Product '%s'." | ||
| msgstr "Fehlendes Anfangsdatum in Auftragsposition des Produkts '%s'." | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model.fields,field_description:sale_start_end_dates.field_sale_order_line__must_have_dates | ||
| msgid "Must Have Start/End Dates" | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model.fields,field_description:sale_start_end_dates.field_sale_order_line__number_of_days | ||
| msgid "Number of Days" | ||
| msgstr "Anzahl Tage" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #. odoo-python | ||
| #: code:addons/sale_start_end_dates/models/sale_order.py:0 | ||
| #, python-format | ||
| msgid "" | ||
| "On sale order line with product '%(product_name)s', the number of days is " | ||
| "negative (%(number_of_days)s) ; this is not allowed. The number of days has " | ||
| "been forced to 1." | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model,name:sale_start_end_dates.model_sale_order | ||
| msgid "Sales Order" | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model,name:sale_start_end_dates.model_sale_order_line | ||
| msgid "Sales Order Line" | ||
| msgstr "Auftragsposition" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #: model:ir.model.fields,field_description:sale_start_end_dates.field_sale_order_line__start_date | ||
| msgid "Start Date" | ||
| msgstr "Anfangsdatum" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #. odoo-python | ||
| #: code:addons/sale_start_end_dates/models/sale_order.py:0 | ||
| #, python-format | ||
| msgid "" | ||
| "Start Date (%(start_date)s) should be before or be the same as End Date " | ||
| "(%(end_date)s) for sale order line with Product '%(product_name)s'." | ||
| msgstr "" | ||
|
|
||
| #. module: sale_start_end_dates | ||
| #. odoo-python | ||
| #: code:addons/sale_start_end_dates/models/sale_order.py:0 | ||
| #, fuzzy, python-format | ||
| msgid "Wrong number of days" | ||
| msgstr "Anzahl Tage" | ||
|
|
||
| #, fuzzy, python-format | ||
| #~| msgid "" | ||
| #~| "Default Start Date should be before or be the same as Default End Date " | ||
| #~| "for sale order %s" | ||
| #~ msgid "" | ||
| #~ "Default Start Date should be before or be the same as Default End Date " | ||
| #~ "for sale order '%s'." | ||
| #~ msgstr "" | ||
| #~ "Vorgabe-Anfangsdatum muss im Auftrag %s vor ooder am Enddatum liegen" | ||
|
|
||
| #~ msgid "Must Have Start and End Dates" | ||
| #~ msgstr "Muss Anfangs- und Enddatum haben" | ||
|
|
||
| #, fuzzy | ||
| #~| msgid "Sales Order" | ||
| #~ msgid "Sale Order" | ||
| #~ msgstr "Verkaufsauftrag" | ||
|
|
||
| #, python-format | ||
| #~ msgid "" | ||
| #~ "Start Date should be before or be the same as End Date for sale order " | ||
| #~ "line with Product '%s'." | ||
| #~ msgstr "" | ||
| #~ "In der Auftragsposition zum Produkt %s muss das Anfangsdatum vor oder am " | ||
| #~ "Enddatum liegen." | ||
|
|
||
| #~ msgid "Missing number of days for sale order line with Product '%s'." | ||
| #~ msgstr "Fehlende Anzahl Tage in Auftragsposition des Produkts '%s'." | ||
|
|
||
| #~ msgid "" | ||
| #~ "On the sale order line with Product '%s', there are %d days between the " | ||
| #~ "Start Date (%s) and the End Date (%s), but the number of days field has a " | ||
| #~ "value of %d days." | ||
| #~ msgstr "" | ||
| #~ "In Auftragsposition des Produkts '%s' liegen %d Tage zwischen Anfangs- " | ||
| #~ "(%s) und Enddatum (%s), das Anzahl Tage -Feld weist jedoch %d Tage aus." |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexis-via Could you put this change in migration commit ? Thanks