Skip to content

Conversation

@stevTresCloud
Copy link

  • In case there is a modification of the view, with studio or a custom development by adding a new tab before the main invoice lines tab, an error occurs with this search because it doesn't find the item in the xpath expression. With this modification, we ensure that the item to search for is in the main invoice lines tab.

@stevTresCloud stevTresCloud force-pushed the TRESCLOUD_18_0_FIX_XPATH branch from 6dce6f8 to b41e8f2 Compare February 5, 2025 15:24
- In case there is a modification of the view, with studio or a custom development by adding a new tab before the main invoice lines tab, an error occurs with this search because it doesn't find the item in the xpath expression. With this modification, we ensure that the item to search for is in the main invoice lines tab.
@stevTresCloud stevTresCloud force-pushed the TRESCLOUD_18_0_FIX_XPATH branch from b41e8f2 to 036d680 Compare February 5, 2025 15:26
Comment on lines +14 to +17
<xpath
expr="//notebook//page[@id='invoice_tab']//list//field[@name='sequence']"
position="before"
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be more specific and simplified to avoid ambiguity, as follows:

Suggested change
<xpath
expr="//notebook//page[@id='invoice_tab']//list//field[@name='sequence']"
position="before"
>
<xpath
expr="//field[@name='invoice_line_ids']//list//field[@name='sequence']"
position="before"
>

I think this field might be unnecessary according to this PR: odoo/odoo#137031. The fields used in other fields/attributes are automatically added as invisible.

@pedrobaeza @StefanRijnhart What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that seems so, so you can remove it directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants