Skip to content

[FIX] sale_order_type: Fix item search in account move view #3569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevTresCloud wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[FIX] sale_order_type: Fix item search in account move view #3569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sale_order_type/views/account_move_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@
readonly="state != 'draft'"
/>
</label>
<xpath expr="//notebook//list//field[@name='sequence']" position="before">
<xpath
expr="//notebook//page[@id='invoice_tab']//list//field[@name='sequence']"
position="before"
>
Comment on lines +14 to +17
Copy link
Contributor

@celm1990 celm1990 Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be more specific and simplified to avoid ambiguity, as follows:

Suggested change
<xpath
expr="//notebook//page[@id='invoice_tab']//list//field[@name='sequence']"
position="before"
>
<xpath
expr="//field[@name='invoice_line_ids']//list//field[@name='sequence']"
position="before"
>

I think this field might be unnecessary according to this PR: odoo/odoo#137031. The fields used in other fields/attributes are automatically added as invisible.

@pedrobaeza @StefanRijnhart What do you think?

Copy link
Member

@pedrobaeza pedrobaeza Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that seems so, so you can remove it directly.

<field name="account_id" column_invisible="True" />
</xpath>
</field>
Expand Down
Loading