[18.0][IMP] base_tier_validation: Make the validation_status field store so that it can be used in searchs #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that it can be used in searchs. Similar to kevinkhao@217de7c TT56391
…ield to validation_status TT56391
|
Hi @kittiu, @LoisRForgeFlow, |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at ece520d. Thanks a lot for contributing to OCA. ❤️ |
There was a problem hiding this comment.
I have the same error with the migration script reported here: OCA/purchase-workflow#2727 (review)
simahawk
reviewed
Aug 12, 2025
pedrobaeza
added a commit
to Tecnativa/stock-logistics-workflow
that referenced
this pull request
Aug 12, 2025
Method `_calc_reviews_validated` has been removed in OCA/server-ux#1138, so this commit adapts the needed changes to it. Fixes OCA#2064
maisim
added a commit
to maisim/server-ux
that referenced
this pull request
Sep 17, 2025
This backports changes from OCA/18.0: - PR OCA#1138: Make validation_status field stored for better search performance - PR OCA#1139: Add migration script to prevent errors during upgrade Changes: * base_tier_validation: Add store=True to validation_status field * base_tier_validation: Add migration script to populate stored field * base_tier_validation_forward: Update test to use validation_status * Version bumps for both modules
maisim
added a commit
to maisim/server-ux
that referenced
this pull request
Sep 17, 2025
This backports changes from OCA/18.0: - PR OCA#1138: Make validation_status field stored for better search performance - PR OCA#1139: Add migration script to prevent errors during upgrade Changes: * base_tier_validation: Add store=True to validation_status field * base_tier_validation: Add migration script to populate stored field * base_tier_validation_forward: Update test to use validation_status * Version bumps for both modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWP from 17.0: #1136
Make the
validation_statusfield store so that it can be used in searchs.Please @pedrobaeza and @carlos-lopez-tecnativa and @StefanRijnhart can you review it?
@Tecnativa TT56391