[15.0][MIG] web_form_banner: Migration to 15.0 #3287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AungKoKoLin1997
force-pushed
the
15.0-mig-web_form_banner
branch
from
1e78c6b to
eca678a
Compare
AungKoKoLin1997
force-pushed
the
15.0-mig-web_form_banner
branch
from
eca678a to
12c8d30
Compare
AungKoKoLin1997
force-pushed
the
15.0-mig-web_form_banner
branch
2 times, most recently
from
f7a2d00 to
2ddbd7e
Compare
AungKoKoLin1997
force-pushed
the
15.0-mig-web_form_banner
branch
from
2ddbd7e to
8f636ba
Compare
yostashiro
suggested changes
Sep 23, 2025
yostashiro
force-pushed
the
15.0-mig-web_form_banner
branch
2 times, most recently
from
28f0455 to
5e9cbdf
Compare
|
@AungKoKoLin1997 Please confirm my commits and sort out the commit history. I think my changes can be squashed into the migration commit but comment the changed points. |
|
@AungKoKoLin1997 Can you also please switch the archive box icon to the banner? 
|
AungKoKoLin1997
force-pushed
the
15.0-mig-web_form_banner
branch
2 times, most recently
from
d3c42d1 to
c58a869
Compare
yostashiro
approved these changes
Sep 25, 2025
Sayaka-qrtl
reviewed
Sep 25, 2025
AungKoKoLin1997
force-pushed
the
15.0-mig-web_form_banner
branch
from
c58a869 to
08d20a8
Compare
yostashiro
force-pushed
the
15.0-mig-web_form_banner
branch
2 times, most recently
from
135d9ee to
854e4d0
Compare
AungKoKoLin1997
force-pushed
the
15.0-mig-web_form_banner
branch
2 times, most recently
from
a9e5a0c to
ff22e4a
Compare
yostashiro
reviewed
Sep 29, 2025
AungKoKoLin1997
force-pushed
the
15.0-mig-web_form_banner
branch
from
ff22e4a to
9264f62
Compare
|
@AungKoKoLin1997 Just noticed an issue with banner presentation. Can you please follow up on this? 
|
Refactor JS: - Switch to the ESM style - Change var to const/let - Remove unused parts (diff, el.dataset.wfbTriggerFields) Miscellaneous improvements: - list view optional - Switch archive box icon to banner Fix _render_html for Odoo 15: - In Odoo 12, html_escape returned a plain string, so replacing newlines with <br/> worked as expected. - In Odoo 15, html_escape uses markupsafe.escape, which escapes inserted <br/> tags resulting in <br/> in the output. - Updated _render_html to escape each line individually and join with literal <br/> tags to match Odoo 12 behavior while remaining safe for HTML rendering. Co-authored-by: Yoshi Tashiro <[email protected]>
AungKoKoLin1997
force-pushed
the
15.0-mig-web_form_banner
branch
from
9264f62 to
c5f828e
Compare
@yostashiro Fixed it and explain the changes in the migration commit message as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3286
@qrtl QT5747