Remove fold on ephemerons #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nberth
force-pushed
the
remove-weak-fold
branch
from
6b1438a
to
4b8ab83
Compare
nberth
force-pushed
the
remove-weak-fold
branch
2 times, most recently
from
e532a7a
to
0c95ca5
Compare
nberth
added
ok to review
nberth
force-pushed
the
remove-weak-fold
branch
from
cf33f52
to
bd0ef1e
Compare
lefessan
reviewed
Sep 21, 2023
|
There are too many unrelated commits in this PR. If you want a review, I think it needs to be splitted in multiple simpler PRs. Typically, changes to |
nberth
force-pushed
the
remove-weak-fold
branch
2 times, most recently
from
d2aefa1
to
2f1306f
Compare
Merged
|
|
This completely removes the need to handle cases of dummy left-most positions in the source overlay module.
nberth
force-pushed
the
remove-weak-fold
branch
from
2f1306f
to
10628f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we had a warning about a function not being available in OCaml 5.