Rewindable parser #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nberth
force-pushed
the
rewindable-parser
branch
from
6d5540c
to
43c8ed3
Compare
|
|
nberth
force-pushed
the
rewindable-parser
branch
2 times, most recently
from
4308ecc
to
4ebba93
Compare
This commit adds the ability to restart parsing only a few tokens before any document change. This should greatly improve performance, especially when editing the middle or end of large files.
nberth
force-pushed
the
rewindable-parser
branch
2 times, most recently
from
454fcdb
to
96c0a1c
Compare
Additionally, use a dedicated token to avoid retokenization of program IDs
nberth
force-pushed
the
rewindable-parser
branch
from
96c0a1c
to
403917f
Compare
nberth
force-pushed
the
rewindable-parser
branch
2 times, most recently
from
85fa05d
to
967b058
Compare
nberth
force-pushed
the
rewindable-parser
branch
from
967b058
to
e420514
Compare
…c_format` These changes remove pointless uses of `Cobol_config.source_format` in the pre-processor.
nberth
force-pushed
the
rewindable-parser
branch
from
a2441c8
to
261193d
Compare
nberth
force-pushed
the
rewindable-parser
branch
from
261193d
to
fa0abb5
Compare
lefessan
reviewed
Oct 5, 2023
bclement-ocp
reviewed
Oct 5, 2023
nberth
force-pushed
the
rewindable-parser
branch
from
ce6bf5c
to
75119bd
Compare
nberth
force-pushed
the
rewindable-parser
branch
from
75119bd
to
8529fff
Compare
ddeclerck
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add the ability to restart parsing only a few tokens before any document change. This should greatly improve performance, especially when editing the middle or end of large files.
Changes also include some refactoring of the parser and pre-processor, with a unification of their interface (notably, with options always passed using a single record).
Some tests of the rewinding feature come as well, along with fixes for some bugs they helped discover ;-).