Closed
Conversation
Member
|
PR looks correct to me. |
inashivb
force-pushed
the
ftp-possible-test-fix/v1
branch
from
fa165c2 to
21a313d
Compare
Member
|
Is this waiting on a Suricata PR? |
Member
Member
Author
|
Merged via #1233 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that we cap the long lines at 4096 bytes and command_data.__len is calculated by
request size - (command size + space) (ref: https://github.com/OISF/suricata/blob/master/src/output-json-ftp.c#L61)
which in this case, 4 (RETR) + 1 = 5
The command_data length should be 4091 bytes.
There are issues w the current code that I'm fixing and couldn't get this test to pass and am wondering now if the test is correct. As per my calculations above, test should be updated. Wdyt @jasonish ?