Conversation
So far, we store one variable in state to hold whether we want to discard a long line till LF irrespective of direction. This means that a long command to the client followed by a regular command w LF can be considered as one long line which is incorrect. Bug 6054
Currently, there is no way to mark if LF was found and then the line was truncated. It becomes difficult to spot in the callers whether the line was truncated despite LF being found or not. So, label it clearly with a variable.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8963 +/- ##
==========================================
- Coverage 82.42% 82.41% -0.01%
==========================================
Files 969 969
Lines 273476 273473 -3
==========================================
- Hits 225410 225384 -26
- Misses 48066 48089 +23
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Jun 6, 2023
|
Information: QA ran without warnings. Pipeline 14256 |
Merged
Member
|
Merged in #8994, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6054
+ fixes and code cleanup
Note: this makes an s-v test for FTP fail. I believe the test needs fixing, which has been done in OISF/suricata-verify#1222.
SV_BRANCH=pr/1222