mqtt: add additional tests for reason codes#2102
Closed
satta wants to merge 3 commits intoOISF:masterfrom
Closed
Conversation
2 tasks
Contributor
|
Current Suricata PR: OISF/suricata#11995 |
jufajardini
requested changes
Oct 24, 2024
Contributor
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
Thanks for this work :)
Contributor
Author
|
Next PR: #2106 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some more checks for situations related to https://forum.suricata.io/t/question-about-mqtt-detection/4890/ among others.
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7323