mqtt: add additional tests for reason codes - v2#2106
Closed
satta wants to merge 3 commits intoOISF:masterfrom
Closed
mqtt: add additional tests for reason codes - v2#2106satta wants to merge 3 commits intoOISF:masterfrom
satta wants to merge 3 commits intoOISF:masterfrom
Conversation
This was referenced Oct 24, 2024
jufajardini
approved these changes
Oct 25, 2024
Contributor
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
It looks good to me now, thanks!
One thing I'm not sure about is the forum linked in the commit message, but I'll let Victor or someone else be the judge for that.
Contributor
Author
The post is also linked in the Redmine ticket, so I could also remove it -- not sure why that would matter though :) |
victorjulien
approved these changes
Nov 4, 2024
Member
|
Merged in #2118, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR: #2102
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7323
Changes to previous PR: