Skip to content

mqtt: Improve handling of multiple PDU parsing #10262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jlucovsky wants to merge 1 commit into from
Closed

mqtt: Improve handling of multiple PDU parsing #10262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rust/src/mqtt/mqtt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,13 +462,13 @@ impl MQTTState {
}

while !current.is_empty() {
SCLogDebug!("request: handling {}", current.len());
SCLogDebug!("request: handling {}; rem: {}", current.len(), input.len() - current.len());
match parse_message(current, self.protocol_version, self.max_msg_len) {
Ok((rem, msg)) => {
let _pdu = Frame::new(
flow,
&stream_slice,
input,
current,
current.len() as i64,
Copy link
Contributor

@catenacyber catenacyber Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it not be current.len()-rem.len() ? (and same below)

Copy link
Contributor Author

@jlucovsky jlucovsky Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will adjust in new pr

MQTTFrameType::Pdu as u8,
);
Expand Down Expand Up @@ -553,8 +553,8 @@ impl MQTTState {
let _pdu = Frame::new(
flow,
&stream_slice,
input,
input.len() as i64,
current,
current.len() as i64,
MQTTFrameType::Pdu as u8,
);

Expand Down