mqtt: Improve handling of multiple PDU parsing#10262
mqtt: Improve handling of multiple PDU parsing#10262jlucovsky wants to merge 1 commit intoOISF:masterfrom
Conversation
|
Information: QA ran without warnings. Pipeline 17783 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10262 +/- ##
==========================================
+ Coverage 82.28% 82.32% +0.03%
==========================================
Files 977 977
Lines 271950 271950
==========================================
+ Hits 223784 223885 +101
+ Misses 48166 48065 -101
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
According to Victor's suggestion (#10058 (comment)):
For reference, you can look here for reference: 7366506#diff-d988869639f4f6ed35c7047322b592a33a7421d22c38aa6137d456967b3656d3R162-R200 |
| &stream_slice, | ||
| input, | ||
| current, | ||
| current.len() as i64, |
There was a problem hiding this comment.
Should it not be current.len()-rem.len() ? (and same below)
There was a problem hiding this comment.
Will adjust in new pr
|
Continued in #10279 |
Continuation of #10236
Issue: 6592
Link to redmine ticket: 6592
Describe changes:
Updates:
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/NwhereNis thepull request number.
Alternatively,
SV_BRANCHmay also be a link to anOISF/suricata-verify pull-request.