Skip to content

Comments

Http uri spaces 2881 v22#10301

Closed
catenacyber wants to merge 2 commits intoOISF:masterfrom
catenacyber:http-uri-spaces-2881-v22
Closed

Http uri spaces 2881 v22#10301
catenacyber wants to merge 2 commits intoOISF:masterfrom
catenacyber:http-uri-spaces-2881-v22

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2881

Describe changes:

  • configures libhtp to allow spaces in URIs

#9843 rebased

OISF/suricata-verify#1483

SV_BRANCH=pr/1483

@codecov
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (244a35d) 73.31% compared to head (e611a7f) 82.34%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10301       +/-   ##
===========================================
+ Coverage   73.31%   82.34%    +9.03%     
===========================================
  Files         895      978       +83     
  Lines      148215   272050   +123835     
===========================================
+ Hits       108666   224029   +115363     
- Misses      39549    48021     +8472     
Flag Coverage Δ
fuzzcorpus 63.60% <76.19%> (+0.11%) ⬆️
suricata-verify 61.49% <80.95%> (-0.03%) ⬇️
unittests 62.85% <19.04%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien self-assigned this Feb 2, 2024
Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

Pipeline 18072

@catenacyber
Copy link
Contributor Author

Rebased in #10980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants