Closed
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #9843 +/- ##
=======================================
Coverage 82.42% 82.43%
=======================================
Files 972 972
Lines 273929 273954 +25
=======================================
+ Hits 225788 225836 +48
+ Misses 48141 48118 -23
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on SURI_TLPR1_alerts_cmp. Pipeline 16642 |
Contributor
Author
|
Rebased in #10301 Victor, why did you put the label as there was no conflict ? (I did not get a notification from just a label) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2881
Describe changes:
Modifies #9501 with rebase and S-V test targeting 8
OISF/suricata-verify#1483
OISF/libhtp#408