detect: do not run tx detection on non established packets#10307
Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
Closed
detect: do not run tx detection on non established packets#10307catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber wants to merge 1 commit intoOISF:masterfrom
Conversation
victorjulien
reviewed
Feb 3, 2024
| } | ||
| } else if (p->proto == IPPROTO_TCP && p->flow->protoctx) { | ||
| FramesPrune(p->flow, p); | ||
| if (p->flags & PKT_STREAM_EST) { |
Member
There was a problem hiding this comment.
should we still call StreamTcpPruneSession in this case? Seems not. Why would an error packet have any effect on state?
Member
|
Setting to draft as it does not pass SV. |
|
WARNING:
Pipeline 18069 |
Contributor
Author
This is only because SV test bug-4903-04 enforces a Why is this RST packet treated as invalid by |
Contributor
Author
|
Replaced by #10322 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows commit 2fb5059, concurrent against #10286
Link to redmine ticket:
Should there be one specific for this ?
Describe changes:
StreamTcpStateDispatchreturning an error value)SV_BRANCH=OISF/suricata-verify#1623
#10304 more complete optimization