dns: add missing dns keywords to schema.json v3#10429
Closed
hadiqaalamdar wants to merge 1 commit intoOISF:masterfrom
Closed
dns: add missing dns keywords to schema.json v3#10429hadiqaalamdar wants to merge 1 commit intoOISF:masterfrom
hadiqaalamdar wants to merge 1 commit intoOISF:masterfrom
Conversation
Found and added missing dns fields in schema.json after manual code review. Added description to these newly added dns fields. Feature OISF#5642
This was referenced Feb 15, 2024
catenacyber
reviewed
Feb 15, 2024
| "type": "integer" | ||
| }, | ||
| "tc": { | ||
| "description": "A 1-bit subfield that specifies if the length of the message exceeds the allowed length", |
Contributor
There was a problem hiding this comment.
this is an abbreviation for "truncated", right ?
Contributor
Author
There was a problem hiding this comment.
yes, I'll add that.
inashivb
reviewed
Feb 15, 2024
| }, | ||
| "sshfp": { | ||
| "type": "object", | ||
| "description": "A Secure Shell fingerprint is used to verify the system’s authenticity", |
Member
There was a problem hiding this comment.
description and type are a bit inconsistently ordered here. I learned from the reviews on my such PR that it is preferred to have description as the first item.
Contributor
Author
There was a problem hiding this comment.
got it, I'll reorder and submit a new PR
This was referenced Feb 15, 2024
Contributor
Author
|
New PR: #10432 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature #5642
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5642
Previous PR: #10401
Describe changes:
SV_BRANCH=OISF/suricata-verify#1588