Skip to content

dns: add missing dns keywords to schema.json v3 #10429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hadiqaalamdar wants to merge 1 commit into from
Closed

dns: add missing dns keywords to schema.json v3 #10429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions etc/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,6 +999,10 @@
"description": "DNS opcode as an integer",
"type": "integer"
},
"tc": {
"description": "A 1-bit subfield that specifies if the length of the message exceeds the allowed length",
Copy link
Contributor

@catenacyber catenacyber Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an abbreviation for "truncated", right ?

Copy link
Contributor Author

@hadiqaalamdar hadiqaalamdar Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I'll add that.

"type": "boolean"
},
"answers": {
"type": "array",
"minItems": 1,
Expand Down Expand Up @@ -1034,6 +1038,22 @@
}
},
"additionalProperties": false
},
"sshfp": {
"type": "object",
"description": "A Secure Shell fingerprint is used to verify the system’s authenticity",
Copy link
Member

@inashivb inashivb Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description and type are a bit inconsistently ordered here. I learned from the reviews on my such PR that it is preferred to have description as the first item.

Copy link
Contributor Author

@hadiqaalamdar hadiqaalamdar Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, I'll reorder and submit a new PR

"properties": {
"fingerprint": {
"type": "string"
},
"algo": {
"type": "integer"
},
"type": {
"type": "integer"
}
},
"additionalProperties": false
}
},
"additionalProperties": false
Expand Down Expand Up @@ -1190,6 +1210,26 @@
"items": {
"type": "string"
}
},
"SSHFP": {
"type": "array",
"description": "A Secure Shell fingerprint is used to verify the system’s authenticity",
"minItems": 1,
"items": {
"type": "object",
"properties": {
"fingerprint": {
"type": "string"
},
"algo": {
"type": "integer"
},
"type": {
"type": "integer"
}
},
"additionalProperties": false
}
}
},
"additionalProperties": false
Expand Down