Closed
Conversation
Accepts escaped quote in escaped string
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10547 +/- ##
==========================================
- Coverage 82.65% 82.58% -0.08%
==========================================
Files 921 922 +1
Lines 246857 245595 -1262
==========================================
- Hits 204049 202824 -1225
+ Misses 42808 42771 -37
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: ERROR: QA failed on SURI_TLPW2_autofp_suri_time. ERROR: QA failed on SURI_TLPW1_files_sha256.
Pipeline 18923 |
Contributor
Author
|
@ct0br0 could you supply me a minimal pcap where we get this hash once more in this PR than with master ? |
Contributor
Author
|
Rebased in #10734 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3487
Describe changes:
Follows #10376 with needed rebase (after commit 3a7a4cd removing function unused parameter tx_id in HTPFileOpen )