Skip to content

Multipart mime 3487 v35#10547

Closed
catenacyber wants to merge 4 commits intoOISF:masterfrom
catenacyber:multipart-mime-3487-v35
Closed

Multipart mime 3487 v35#10547
catenacyber wants to merge 4 commits intoOISF:masterfrom
catenacyber:multipart-mime-3487-v35

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3487

Describe changes:

  • convert HTTP to use new rust mime parser
  • convert SMTP to use new rust mime parser

Follows #10376 with needed rebase (after commit 3a7a4cd removing function unused parameter tx_id in HTPFileOpen )

@codecov
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 87.34622% with 144 lines in your changes are missing coverage. Please review.

Project coverage is 82.58%. Comparing base (5f08535) to head (16a0561).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10547      +/-   ##
==========================================
- Coverage   82.65%   82.58%   -0.08%     
==========================================
  Files         921      922       +1     
  Lines      246857   245595    -1262     
==========================================
- Hits       204049   202824    -1225     
+ Misses      42808    42771      -37     
Flag Coverage Δ
fuzzcorpus 63.86% <75.00%> (-0.16%) ⬇️
suricata-verify 61.60% <81.76%> (-0.10%) ⬇️
unittests 62.08% <57.64%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

ERROR: QA failed on SURI_TLPW1_files_sha256.

field baseline test %
SURI_TLPW2_autofp_stats_chk
.flow.end.tcp_state.established 8 13 162.5%
SURI_TLPW1_stats_chk
.uptime 178 184 103.37%

Pipeline 18923

@catenacyber
Copy link
Contributor Author

@ct0br0 could you supply me a minimal pcap where we get this hash once more in this PR than with master ?

@catenacyber
Copy link
Contributor Author

Rebased in #10734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants