Skip to content

Multipart mime 3487 v36#10734

Closed
catenacyber wants to merge 4 commits intoOISF:masterfrom
catenacyber:multipart-mime-3487-v36
Closed

Multipart mime 3487 v36#10734
catenacyber wants to merge 4 commits intoOISF:masterfrom
catenacyber:multipart-mime-3487-v36

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3487

Describe changes:

  • convert HTTP to use new rust mime parser
  • convert SMTP to use new rust mime parser

Follows #10547 with needed rebase after e38ec7d (ignoring it as rust does it differently)

@codecov
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 87.34622% with 144 lines in your changes are missing coverage. Please review.

Project coverage is 82.68%. Comparing base (ee50fe4) to head (a7376a6).
Report is 125 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10734      +/-   ##
==========================================
+ Coverage   78.52%   82.68%   +4.16%     
==========================================
  Files         926      926              
  Lines      247464   246277    -1187     
==========================================
+ Hits       194331   203645    +9314     
+ Misses      53133    42632   -10501     
Flag Coverage Δ
fuzzcorpus 64.07% <75.00%> (-0.17%) ⬇️
suricata-verify 61.88% <81.76%> (?)
unittests 62.06% <57.64%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on SURI_TLPW1_files_sha256.

Pipeline 19877

@catenacyber
Copy link
Contributor Author

#10739 fixes the root cause for not having one file missing in master with QA SURI_TLPW1_files_sha256

@jufajardini jufajardini added the needs rebase Needs rebase to main label Apr 18, 2024
@catenacyber catenacyber marked this pull request as draft April 18, 2024 11:51
@catenacyber
Copy link
Contributor Author

Will rebase after merge of #10739

@catenacyber
Copy link
Contributor Author

Rebased in #11115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs rebase Needs rebase to main

Development

Successfully merging this pull request may close these issues.

3 participants