Skip to content

userguide: fix explanation about bsize ranges (7.0.x backport) - v1#10571

Closed
jufajardini wants to merge 1 commit intoOISF:main-7.0.xfrom
jufajardini:bsize-ranges-docs-70x/v1
Closed

userguide: fix explanation about bsize ranges (7.0.x backport) - v1#10571
jufajardini wants to merge 1 commit intoOISF:main-7.0.xfrom
jufajardini:bsize-ranges-docs-70x/v1

Conversation

@jufajardini
Copy link
Contributor

Our code handles Uint ranges as exclusive, but for bsize, our
documentation stated that they're inclusive.

Cf. from uint.rs:

    DetectUintMode::DetectUintModeRange => {
        if val > x.arg1 && val < x.arg2 {
            return true;
        }
    }

Task OISF#6708

(cherry picked from commit 244a35d)
@codecov
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.49%. Comparing base (b6c609e) to head (b5074ab).

Additional details and impacted files
@@              Coverage Diff               @@
##           main-7.0.x   #10571      +/-   ##
==============================================
+ Coverage       82.43%   82.49%   +0.06%     
==============================================
  Files             976      976              
  Lines          275046   275046              
==============================================
+ Hits           226726   226909     +183     
+ Misses          48320    48137     -183     
Flag Coverage Δ
fuzzcorpus 63.62% <ø> (+0.17%) ⬆️
suricata-verify 61.66% <ø> (-0.03%) ⬇️
unittests 62.90% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien
Copy link
Member

Merged in #10587, thanks!

@jufajardini jufajardini deleted the bsize-ranges-docs-70x/v1 branch March 8, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants