Skip to content

next/329/70x/20240307/v1#10587

Merged
victorjulien merged 2 commits intoOISF:main-7.0.xfrom
victorjulien:next/329/70x/20240307/v1
Mar 8, 2024
Merged

next/329/70x/20240307/v1#10587
victorjulien merged 2 commits intoOISF:main-7.0.xfrom
victorjulien:next/329/70x/20240307/v1

Conversation

@victorjulien
Copy link
Member

@victorjulien victorjulien commented Mar 7, 2024

lukashino and others added 2 commits March 7, 2024 16:31
@lukashino @victorjulien
doc: mention the limited number of RX/TX descriptors on Intel NICs
1814e81 
Ticket: 6748
(cherry picked from commit 356f9ff)
@jufajardini @victorjulien
userguide: fix explanation about bsize ranges
2efde5b 
Our code handles Uint ranges as exclusive, but for bsize, our
documentation stated that they're inclusive.

Cf. from uint.rs:

    DetectUintMode::DetectUintModeRange => {
        if val > x.arg1 && val < x.arg2 {
            return true;
        }
    }

Task OISF#6708

(cherry picked from commit 244a35d)
@victorjulien victorjulien merged commit 2efde5b into OISF:main-7.0.x Mar 8, 2024
This was referenced Mar 8, 2024
Closed
Closed
@victorjulien victorjulien deleted the next/329/70x/20240307/v1 branch March 8, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonish jasonish jasonish approved these changes

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@victorjulien @jasonish @lukashino @jufajardini