smtp: exit data mode if data command was rejected#10739
Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
Closed
smtp: exit data mode if data command was rejected#10739catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber wants to merge 1 commit intoOISF:masterfrom
Conversation
And the server was advertising pipelining. Ticket: 6906
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10739 +/- ##
==========================================
+ Coverage 78.52% 82.66% +4.13%
==========================================
Files 926 926
Lines 247464 247656 +192
==========================================
+ Hits 194331 204714 +10383
+ Misses 53133 42942 -10191
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on SURI_TLPW1_files_sha256. Pipeline 19888 |
Contributor
|
This one looks good to me. Is anything preventing its approval, or are we waiting as this will require a QA rebase line? |
Contributor
Author
I guess this is not the priority before the release, cc @victorjulien ? |
Contributor
Author
|
Rebased in #10981 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6906
Describe changes:
Will need a QA rebase line as #10734
OISF/suricata-verify#1737