Skip to content

JA4 for TLS and QUIC -- v11#10829

Closed
satta wants to merge 3 commits intoOISF:masterfrom
satta:6379-ja4-v11
Closed

JA4 for TLS and QUIC -- v11#10829
satta wants to merge 3 commits intoOISF:masterfrom
satta:6379-ja4-v11

Conversation

@satta
Copy link
Contributor

@satta satta commented Apr 12, 2024

Previous PR: #10725

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6379

Changes to previous PR:

  • Rebase against current master.
  • Put stray JA4 line into correct commit.
  • Add comment explaining why nof_exts is used as a separate field.
  • Use Rust's std::cmp::min instead of using explicit ifs.
  • Adopt the new style guard headers prefixed with SURICATA and without leading/trailing underscores.
  • Condense JA4/JA3 documentation into single RST document.
SV_BRANCH=pr/1761

@satta
Copy link
Contributor Author

satta commented Apr 12, 2024

No idea about the single failing test, seems unrelated to the PR.

@codecov
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 83.54701% with 77 lines in your changes are missing coverage. Please review.

Project coverage is 82.69%. Comparing base (172b55c) to head (4336ec7).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10829      +/-   ##
==========================================
- Coverage   82.75%   82.69%   -0.06%     
==========================================
  Files         928      931       +3     
  Lines      247913   248332     +419     
==========================================
+ Hits       205162   205370     +208     
- Misses      42751    42962     +211     
Flag Coverage Δ
fuzzcorpus 64.07% <64.28%> (-0.17%) ⬇️
suricata-verify 62.13% <83.70%> (+0.13%) ⬆️
unittests 62.15% <44.23%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien
Copy link
Member

No idea about the single failing test, seems unrelated to the PR.

Agreed, a restart fixed it.

@victorjulien
Copy link
Member

Thanks @satta, I think this looks really good. A few comments inline.

@satta
Copy link
Contributor Author

satta commented Apr 14, 2024

New PR: #10836

@satta satta closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants