Closed
Conversation
This gives app layer code a chance to access feature information.
Contributor
Author
|
No idea about the single failing test, seems unrelated to the PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10829 +/- ##
==========================================
- Coverage 82.75% 82.69% -0.06%
==========================================
Files 928 931 +3
Lines 247913 248332 +419
==========================================
+ Hits 205162 205370 +208
- Misses 42751 42962 +211
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
Agreed, a restart fixed it. |
Member
|
Thanks @satta, I think this looks really good. A few comments inline. |
Contributor
Author
|
New PR: #10836 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR: #10725
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6379
Changes to previous PR:
nof_extsis used as a separate field.std::cmp::mininstead of using explicitifs.SURICATAand without leading/trailing underscores.