Closed
Conversation
This gives app layer code a chance to access feature information.
satta
requested review from
a team,
catenacyber,
jasonish,
jufajardini and
victorjulien
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10836 +/- ##
==========================================
+ Coverage 82.67% 82.73% +0.06%
==========================================
Files 928 931 +3
Lines 247912 248332 +420
==========================================
+ Hits 204952 205461 +509
+ Misses 42960 42871 -89
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Apr 16, 2024
Merged
Member
|
Merged in #10856, thanks! |
Contributor
|
Thank you Sascha :-) |
catenacyber
reviewed
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR: #10829
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6379
Changes to previous PR:
SV_BRANCH=OISF/suricata-verify#1761