Merged
Conversation
This gives app layer code a chance to access feature information.
It was brought to my attention by GLongo that Pgsql parser handled eof diffrently for requests and responses, and apparently there isn't a good reason for such a difference therefore, apply same logic used for rs_pgsql_parse_request for checking for eof when parsing a response.
victorjulien
requested review from
a team,
catenacyber,
jasonish and
jufajardini
as code owners
Member
|
Missing #10855 on purpose? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10856 +/- ##
==========================================
+ Coverage 82.88% 82.95% +0.07%
==========================================
Files 914 917 +3
Lines 246936 247361 +425
==========================================
+ Hits 204671 205198 +527
+ Misses 42265 42163 -102
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
Author
Yes, this run had already started before that PR was made or approved. |
|
WARNING:
Pipeline 20086 |
This was referenced Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#1771