Skip to content

Comments

snmp: remove community keyword unit test#11020

Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:snmp-sv-test-3725-v1
Closed

snmp: remove community keyword unit test#11020
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:snmp-sv-test-3725-v1

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
Part of https://redmine.openinfosecfoundation.org/issues/3725

Describe changes:

Ticket: 3725

This test was moved to suricata-verify snmp-community
@catenacyber catenacyber requested a review from victorjulien as a code owner May 4, 2024 19:40
@catenacyber
Copy link
Contributor Author

This is a first part of getting rid of C files for SNMP cf #10992

@codecov
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.60%. Comparing base (f14a4a1) to head (bdf3168).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11020      +/-   ##
==========================================
+ Coverage   80.66%   83.60%   +2.93%     
==========================================
  Files         923      922       -1     
  Lines      250204   250321     +117     
==========================================
+ Hits       201833   209279    +7446     
+ Misses      48371    41042    -7329     
Flag Coverage Δ
fuzzcorpus 64.20% <100.00%> (-0.11%) ⬇️
livemode 18.55% <100.00%> (+0.12%) ⬆️
suricata-verify 62.74% <100.00%> (?)
unittests 62.26% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 20501

@victorjulien victorjulien added this to the 8.0 milestone May 5, 2024
@victorjulien
Copy link
Member

Merged in #11023, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants