Conversation
Accepts escaped quote in escaped string
catenacyber
requested review from
a team,
jasonish and
victorjulien
as code owners
jlucovsky
left a comment
jlucovsky
left a comment
There was a problem hiding this comment.
just a few nits -- copyright dates.
LGTM
| @@ -0,0 +1,569 @@ | |||
| /* Copyright (C) 2021 Open Information Security Foundation | |||
| @@ -1,4 +1,4 @@ | |||
| /* Copyright (C) 2021 Open Information Security Foundation | |||
| /* Copyright (C) 2022 Open Information Security Foundation | |||
| @@ -0,0 +1,844 @@ | |||
| /* Copyright (C) 2022 Open Information Security Foundation | |||
There was a problem hiding this comment.
date, here and everywhere
| size_t new_val_len = strlen(scheme->val) + 3 + 1; | ||
| if (new_val_len > UINT16_MAX) { | ||
| size_t scheme_len = strlen(scheme->val); | ||
| if (scheme_len > UINT16_MAX - SCHEME_SUFFIX_LEN) { |
There was a problem hiding this comment.
nit: even though - has higher precedence than >, I'd prefer paren's around UINT16_MAX - SCHEME_SUFFIX_LEN)
|
Information: QA ran without warnings. Pipeline 20760 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11130 +/- ##
==========================================
- Coverage 84.26% 84.13% -0.14%
==========================================
Files 926 926
Lines 247387 246010 -1377
==========================================
- Hits 208453 206970 -1483
- Misses 38934 39040 +106
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
left a comment
victorjulien
left a comment
There was a problem hiding this comment.
Needs rebase due to a conflict.
Can you update the years while at it?
Rebased in #11157
Confused about this : |
4 participants
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3487
Describe changes:
Follows #11115 with rebase to get more SV test + adding a field in json schema from this test
SV_BRANCH=OISF/suricata-verify#1851