Skip to content

Multipart mime 3487 v37#11115

Closed
catenacyber wants to merge 4 commits intoOISF:masterfrom
catenacyber:multipart-mime-3487-v37
Closed

Multipart mime 3487 v37#11115
catenacyber wants to merge 4 commits intoOISF:masterfrom
catenacyber:multipart-mime-3487-v37

Conversation

@catenacyber
Copy link
Contributor

@catenacyber catenacyber commented May 22, 2024

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3487

Describe changes:

  • convert HTTP to use new rust mime parser
  • convert SMTP to use new rust mime parser

Follows #10734 with needed rebase

There should be no more QA diff after merge of #10981 and rebaseline

SV_BRANCH=OISF/suricata-verify#1847

@catenacyber
Copy link
Contributor Author

I need to do a SV PR to modify the behavior and no longer error on bug-1449

@codecov
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 87.34622% with 144 lines in your changes are missing coverage. Please review.

Project coverage is 83.85%. Comparing base (0aaec69) to head (be7bec2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11115      +/-   ##
==========================================
- Coverage   84.10%   83.85%   -0.26%     
==========================================
  Files         926      926              
  Lines      250712   249335    -1377     
==========================================
- Hits       210858   209074    -1784     
- Misses      39854    40261     +407     
Flag Coverage Δ
fuzzcorpus 64.01% <74.81%> (-0.18%) ⬇️
livemode 19.68% <2.53%> (+0.11%) ⬆️
pcap ?
suricata-verify 62.66% <81.86%> (-0.17%) ⬇️
unittests 62.08% <57.64%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien
Copy link
Member

Not sure if we lack tests of if this is due to CI failures, but it would be nice to make sure we have tests covering the smtp output logic here https://app.codecov.io/gh/OISF/suricata/pull/11115/blob/rust/src/mime/smtp_log.rs

@ct0br0
Copy link

ct0br0 commented May 23, 2024

qa tokens ran out. ignore the 'pipeline canceled' incoming

@catenacyber
Copy link
Contributor Author

Not sure if we lack tests of if this is due to CI failures, but it would be nice to make sure we have tests covering the smtp output logic here https://app.codecov.io/gh/OISF/suricata/pull/11115/blob/rust/src/mime/smtp_log.rs

Would you have a pcap with Bcc: ?

Otherwise, next rebased PR will use next extended SV tests ;-)

@catenacyber
Copy link
Contributor Author

Continued in #11130

@victorjulien
Copy link
Member

Not sure if we lack tests of if this is due to CI failures, but it would be nice to make sure we have tests covering the smtp output logic here https://app.codecov.io/gh/OISF/suricata/pull/11115/blob/rust/src/mime/smtp_log.rs

Would you have a pcap with Bcc: ?

Otherwise, next rebased PR will use next extended SV tests ;-)

I don't think I have. Or at least not sure how to quickly find it.

@catenacyber
Copy link
Contributor Author

I did git grep Bcc: .. | grep pcap in suricata-verify/tests and there were no results, if you have somewhere else to grep ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants