Conversation
Accepts escaped quote in escaped string
|
I need to do a SV PR to modify the behavior and no longer error on bug-1449 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11115 +/- ##
==========================================
- Coverage 84.10% 83.85% -0.26%
==========================================
Files 926 926
Lines 250712 249335 -1377
==========================================
- Hits 210858 209074 -1784
- Misses 39854 40261 +407
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Not sure if we lack tests of if this is due to CI failures, but it would be nice to make sure we have tests covering the smtp output logic here https://app.codecov.io/gh/OISF/suricata/pull/11115/blob/rust/src/mime/smtp_log.rs |
|
qa tokens ran out. ignore the 'pipeline canceled' incoming |
Would you have a pcap with Otherwise, next rebased PR will use next extended SV tests ;-) |
|
Continued in #11130 |
I don't think I have. Or at least not sure how to quickly find it. |
|
I did |
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3487
Describe changes:
Follows #10734 with needed rebase
There should be no more QA diff after merge of #10981 and rebaseline
SV_BRANCH=OISF/suricata-verify#1847