Preparation commits for Dns over http2 5773 v10.1#11226
Closed
catenacyber wants to merge 2 commits intoOISF:masterfrom
Closed
Preparation commits for Dns over http2 5773 v10.1#11226catenacyber wants to merge 2 commits intoOISF:masterfrom
catenacyber wants to merge 2 commits intoOISF:masterfrom
Conversation
Contributor
Author
|
@jasonish would you know if is there a linter for unneeded mut ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11226 +/- ##
=======================================
Coverage 83.02% 83.02%
=======================================
Files 942 942
Lines 250606 250606
=======================================
Hits 208067 208067
Misses 42539 42539
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Jun 4, 2024
jasonish
approved these changes
Jun 4, 2024
Member
I guess not for this case.. For simpler cases of a parameter like |
Merged
Member
|
Merged in #11236, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None preliminary work for https://redmine.openinfosecfoundation.org/issues/5773
Describe changes:
mut