Skip to content

Comments

Preparation commits for Dns over http2 5773 v10.1#11226

Closed
catenacyber wants to merge 2 commits intoOISF:masterfrom
catenacyber:dns-over-http2-5773-v10.1
Closed

Preparation commits for Dns over http2 5773 v10.1#11226
catenacyber wants to merge 2 commits intoOISF:masterfrom
catenacyber:dns-over-http2-5773-v10.1

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
None preliminary work for https://redmine.openinfosecfoundation.org/issues/5773

Describe changes:

@catenacyber catenacyber requested review from a team and jasonish as code owners June 4, 2024 06:48
@catenacyber
Copy link
Contributor Author

@jasonish would you know if is there a linter for unneeded mut ?

@codecov
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.02%. Comparing base (3b1fecb) to head (71b68f9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11226   +/-   ##
=======================================
  Coverage   83.02%   83.02%           
=======================================
  Files         942      942           
  Lines      250606   250606           
=======================================
  Hits       208067   208067           
  Misses      42539    42539           
Flag Coverage Δ
fuzzcorpus 61.28% <100.00%> (ø)
livemode 18.70% <0.00%> (ø)
pcap 44.53% <100.00%> (-0.04%) ⬇️
suricata-verify 61.71% <100.00%> (-0.01%) ⬇️
unittests 60.64% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien added this to the 8.0 milestone Jun 4, 2024
@jasonish
Copy link
Member

jasonish commented Jun 4, 2024

@jasonish would you know if is there a linter for unneeded mut ?

I guess not for this case.. For simpler cases of a parameter like mut foo: bool it will, but not for the reference.

@victorjulien
Copy link
Member

Merged in #11236, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants