Merged
Conversation
'dir' was too generic, so indicate it's about the app-layer update direction.
'dir' was too generic, so indicate it's about the app-layer update direction.
Getter for the most recent frame with unknown length (-1).
AppLayerFrameGetLastOpenByType: Returns the most recent frame with a type with unknown length (-1). Check if type is globally enabled first.
Make sure to only scan the data when the app layer has been updated as well. Ticket: OISF#6718.
Add new flags to trigger FLOW_TS_APP_UPDATED/FLOW_TC_APP_UPDATED flags to be set for the next packet in the relevant direction. This allows for app relevant work to be done in the next packet in our direction.
Inspect frames in the correct direction after they have been created.
There will generally not be an opposing direction to handle the app update.
Adds the following frames: command_line data response_line The *_line frames are per line, so in multi-line responses each line will have it's own frame. Ticket: OISF#4905.
victorjulien
requested review from
a team,
jasonish and
jufajardini
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11236 +/- ##
==========================================
+ Coverage 82.96% 82.99% +0.02%
==========================================
Files 942 942
Lines 249246 249358 +112
==========================================
+ Hits 206789 206951 +162
+ Misses 42457 42407 -50
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
approved these changes
Jun 4, 2024
|
Information: QA ran without warnings. Pipeline 20951 |
inashivb
reviewed
Jun 5, 2024
| A single line from the client to the server. Multi-line commands will have a frame per | ||
| line. Lines part of the SMTP DATA transfer are excluded. | ||
|
|
||
| .. container:: example fule |
Member
There was a problem hiding this comment.
There's a typo in the name of the CSS container. These rules may not render as intended. It should be example-rule.
This was referenced Jun 5, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#1887