Closed
Conversation
THashInitConfig may not allocate array and increase memuse. Such a failure leads to THashShutdown which should not decrease the memuse. Ticket: 7135
Ticket: 5053
Ticket: 5053
Ticket: 5053
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11429 +/- ##
==========================================
- Coverage 82.44% 82.27% -0.17%
==========================================
Files 938 938
Lines 248086 248117 +31
==========================================
- Hits 204534 204139 -395
- Misses 43552 43978 +426
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 21377 |
Member
|
Crashes in unix socket test, see https://github.com/OISF/suricata/actions/runs/9796182048/job/27076990040?pr=11429#step:15:1424 |
Contributor
Author
|
Indeed, I need to reproduce locally to understand why the initialization/clean is wrong here... |
Contributor
Author
|
Continued in #11473 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053
Describe changes:
Small PR good in itself.
#11373 next round
Based on #11426 with review taken into account
Still more work to do : I guess stack allocated arrays are fine, but the global variables cf
git grep '\[ALPROTO_MAX'inneed to be allocated and freed, with taking care of the initialization order, so that we know
ALPROTO_MAXfinal value...