Closed
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11473 +/- ##
==========================================
+ Coverage 82.52% 82.57% +0.04%
==========================================
Files 938 938
Lines 248297 248318 +21
==========================================
+ Hits 204917 205037 +120
+ Misses 43380 43281 -99
Flags with carried forward coverage won't be shown. Click here to find out more. |
d9a0d6c to
5f3cf58
Compare
Ticket: 5053
Ticket: 5053
|
WARNING: ERROR: QA failed on SURI_TLPW1_suri_time. ERROR: QA failed on SURI_TLPR1_suri_time. ERROR: QA failed on SURI_TLPR1_alerts_cmp.
Pipeline 21472 |
5f3cf58 to
9e5a880
Compare
|
Information: ERROR: QA failed on SURI_TLPW2_autofp_suri_time.
Pipeline 21510 |
Contributor
Author
|
Continues in #11507 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053
Describe changes:
Small PR good in itself.
#11373 next round
Based on #11429 with unix socket run mode crash fix, and improvement for run modes, where the global variable just become a local stack allocated one, propagated to the callees
Still more work to do : I guess stack allocated arrays are fine, but the global variables cf
git grep '\[ALPROTO_MAX'inneed to be allocated and freed, with taking care of the initialization order, so that we know
ALPROTO_MAXfinal value...