Skip to content

Applayer plugin 5053 v2.9#11554

Closed
catenacyber wants to merge 3 commits intoOISF:masterfrom
catenacyber:applayer-plugin-5053-v2.9
Closed

Applayer plugin 5053 v2.9#11554
catenacyber wants to merge 3 commits intoOISF:masterfrom
catenacyber:applayer-plugin-5053-v2.9

Conversation

@catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053

Describe changes:

  • get ready to use dynamic number of app-layer protos for some global arrays : run modes and output

Small PR that should be good in itself.

#11373 next round

Based on #11532 with needed rebase after DOH2 merge

Still more work to do : I guess stack allocated arrays are fine, but the global variables cf git grep '\[ALPROTO_MAX' in

  • app-layer-detect-proto.c
  • app-layer-frames.c
  • app-layer-parser.c
  • app-layer-protos.c
  • app-layer.c
    need to be allocated and freed, with taking care of the initialization order, so that we know ALPROTO_MAX final value...

@codecov
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 92.06349% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.52%. Comparing base (7f6c963) to head (0cec6b8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11554      +/-   ##
==========================================
+ Coverage   82.51%   82.52%   +0.01%     
==========================================
  Files         923      923              
  Lines      248732   248769      +37     
==========================================
+ Hits       205232   205295      +63     
+ Misses      43500    43474      -26     
Flag Coverage Δ
fuzzcorpus 60.64% <74.60%> (+0.24%) ⬆️
livemode 18.65% <79.36%> (+0.02%) ⬆️
pcap 44.06% <87.30%> (-0.03%) ⬇️
suricata-verify 61.76% <87.30%> (+0.01%) ⬆️
unittests 59.07% <60.31%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

ERROR: QA failed on SURI_TLPR1_suri_time.

field baseline test %
SURI_TLPW2_autofp_stats_chk
.uptime 138 147 106.52%
SURI_TLPR1_stats_chk
.uptime 648 697 107.56%

Pipeline 21729

@catenacyber
Copy link
Contributor Author

Rebased in #11572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants