Skip to content

Applayer plugin 5053 v2.8#11532

Closed
catenacyber wants to merge 3 commits intoOISF:masterfrom
catenacyber:applayer-plugin-5053-v2.8
Closed

Applayer plugin 5053 v2.8#11532
catenacyber wants to merge 3 commits intoOISF:masterfrom
catenacyber:applayer-plugin-5053-v2.8

Conversation

@catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053

Describe changes:

  • get ready to use dynamic number of app-layer protos for some global arrays : run modes and output

Small PR that should be good in itself.

#11373 next round

Based on #11507 with needed rebase after LDAP and green CI

Still more work to do : I guess stack allocated arrays are fine, but the global variables cf git grep '\[ALPROTO_MAX' in

  • app-layer-detect-proto.c
  • app-layer-frames.c
  • app-layer-parser.c
  • app-layer-protos.c
  • app-layer.c
    need to be allocated and freed, with taking care of the initialization order, so that we know ALPROTO_MAX final value...

@codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 91.93548% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.50%. Comparing base (6598a69) to head (d6ae9e6).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11532      +/-   ##
==========================================
- Coverage   82.54%   82.50%   -0.04%     
==========================================
  Files         923      923              
  Lines      248460   248496      +36     
==========================================
- Hits       205083   205028      -55     
- Misses      43377    43468      +91     
Flag Coverage Δ
fuzzcorpus 60.39% <74.19%> (-0.13%) ⬇️
livemode 18.67% <79.03%> (+0.02%) ⬆️
pcap 44.05% <87.09%> (+0.06%) ⬆️
suricata-verify 61.75% <87.09%> (+0.02%) ⬆️
unittests 59.11% <59.67%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21627

@catenacyber catenacyber added the needs rebase Needs rebase to main label Jul 26, 2024
@catenacyber
Copy link
Contributor Author

Rebased in #11554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs rebase Needs rebase to main

Development

Successfully merging this pull request may close these issues.

2 participants