Skip to content

detect/analyzer: add more details for the tcp window keyword-v2 #12024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nancyenos wants to merge 1 commit into from
Closed

detect/analyzer: add more details for the tcp window keyword-v2 #12024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/detect-engine-analyzer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
#include "detect-flowbits.h"
#include "util-var-name.h"
#include "detect-icmp-id.h"
#include "detect-tcp-window.h"

static int rule_warnings_only = 0;

Expand Down Expand Up @@ -932,6 +933,14 @@ static void DumpMatches(RuleAnalyzer *ctx, JsonBuilder *js, const SigMatchData *
jb_close(js);
break;
}
case DETECT_WINDOW: {
const DetectWindowData *wd = (const DetectWindowData *)smd->ctx;
jb_open_object(js, "window");
jb_set_uint(js, "size", wd->size);
jb_set_bool(js, "negated", wd->negated);
jb_close(js);
break;
}
Comment on lines +936 to +943
Copy link
Member

@inashivb inashivb Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Congrats! :)
I think your suricata-verify PR needs work though

}
jb_close(js);

Expand Down