detect/analyzer: add more details for the tcp window keyword-v2#12024
Closed
Nancyenos wants to merge 1 commit intoOISF:masterfrom
Closed
detect/analyzer: add more details for the tcp window keyword-v2#12024Nancyenos wants to merge 1 commit intoOISF:masterfrom
Nancyenos wants to merge 1 commit intoOISF:masterfrom
Conversation
inashivb
reviewed
Oct 24, 2024
Comment on lines
+936
to
+943
| case DETECT_WINDOW: { | ||
| const DetectWindowData *wd = (const DetectWindowData *)smd->ctx; | ||
| jb_open_object(js, "window"); | ||
| jb_set_uint(js, "size", wd->size); | ||
| jb_set_bool(js, "negated", wd->negated); | ||
| jb_close(js); | ||
| break; | ||
| } |
Member
There was a problem hiding this comment.
This is looking good. Congrats! :)
I think your suricata-verify PR needs work though
2 tasks
jufajardini
added
outreachy
jufajardini
requested changes
Oct 24, 2024
Contributor
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
Once the SV work is sorted, you can also rebase the work here and submit a new PR :)
Contributor
Author
ok.will do |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12024 +/- ##
==========================================
- Coverage 83.24% 79.67% -3.58%
==========================================
Files 910 910
Lines 258136 257966 -170
==========================================
- Hits 214895 205529 -9366
- Misses 43241 52437 +9196
Flags with carried forward coverage won't be shown. Click here to find out more. |
2 tasks
Contributor
Author
|
work continued in #12035 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: 6352
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to ticket: https://redmine.openinfosecfoundation.org/issues/6352
Describe changes:
-Add more details for the tcp-window keyword
Provide values to any of the below to override the defaults.
SV_BRANCH=OISF/suricata-verify#2104