detect/analyzer: add more details for the tcp window keyword-v3#12035
Closed
Nancyenos wants to merge 1 commit intoOISF:masterfrom
Closed
detect/analyzer: add more details for the tcp window keyword-v3#12035Nancyenos wants to merge 1 commit intoOISF:masterfrom
Nancyenos wants to merge 1 commit intoOISF:masterfrom
Conversation
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12035 +/- ##
=======================================
Coverage 83.42% 83.42%
=======================================
Files 910 910
Lines 257642 257649 +7
=======================================
+ Hits 214934 214940 +6
- Misses 42708 42709 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Nov 4, 2024
Member
|
No 8.0 milestone? |
Merged
Member
|
Merged in #12088, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: 6352
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to ticket: https://redmine.openinfosecfoundation.org/issues/6352
Describe changes:
Provide values to any of the below to override the defaults.
SV_BRANCH=OISF/suricata-verify#2107