misc: Remove duplicate function declarations#12044
Closed
Nancyenos wants to merge 1 commit intoOISF:masterfrom
Closed
misc: Remove duplicate function declarations#12044Nancyenos wants to merge 1 commit intoOISF:masterfrom
Nancyenos wants to merge 1 commit intoOISF:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12044 +/- ##
=======================================
Coverage 83.42% 83.43%
=======================================
Files 910 910
Lines 257642 257642
=======================================
+ Hits 214934 214956 +22
+ Misses 42708 42686 -22
Flags with carried forward coverage won't be shown. Click here to find out more. |
catenacyber
reviewed
Oct 28, 2024
| @@ -104,7 +104,6 @@ struct PktPool_; | |||
| * PACKET_RECYCLE and PACKET_CLEANUP macro's. */ | |||
| typedef struct AppLayerDecoderEvents_ AppLayerDecoderEvents; | |||
| void AppLayerDecoderEventsResetEvents(AppLayerDecoderEvents *events); | |||
Contributor
There was a problem hiding this comment.
AppLayerDecoderEventsResetEvents is also duplicated, right ?
catenacyber
reviewed
Oct 28, 2024
| bool DetectRunFrameInspectRule(ThreadVars *tv, DetectEngineThreadCtx *det_ctx, const Signature *s, | ||
| Flow *f, Packet *p, const Frames *frames, const Frame *frame); | ||
|
|
||
| int PrefilterGenericMpmFrameRegister(DetectEngineCtx *de_ctx, SigGroupHead *sgh, MpmCtx *mpm_ctx, |
Contributor
There was a problem hiding this comment.
There is also PrefilterGenericMpmPktRegister duplicate
2 tasks
Contributor
Author
|
work continued in #12047 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #7297
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7297
Describe changes:
-continuation of Remove duplicate function declarations-v6 #12030