misc: Remove duplicate function declarations-v8#12047
Closed
Nancyenos wants to merge 1 commit intoOISF:masterfrom
Closed
misc: Remove duplicate function declarations-v8#12047Nancyenos wants to merge 1 commit intoOISF:masterfrom
Nancyenos wants to merge 1 commit intoOISF:masterfrom
Conversation
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12047 +/- ##
==========================================
- Coverage 83.42% 79.84% -3.58%
==========================================
Files 910 910
Lines 257642 257465 -177
==========================================
- Hits 214934 205584 -9350
- Misses 42708 51881 +9173
Flags with carried forward coverage won't be shown. Click here to find out more. |
jufajardini
approved these changes
Oct 29, 2024
Contributor
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
Comparing this to the review in the last PR and the output of running
cat src/*.h | sort | uniq -c | awk '$1 == 2'It seems that we're good now.
victorjulien
approved these changes
Nov 4, 2024
Merged
Member
|
Merged in #12088, thanks! |
Contributor
|
Thanks Nancy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #7297
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Describe changes:
remove duplicate function declaration
-continuation of pr Remove duplicate function declarations-v6 #12030
previous pr misc: Remove duplicate function declarations #12044