Closed
Conversation
Closed
jasonish
approved these changes
Nov 27, 2024
Member
jasonish
left a comment
jasonish
left a comment
There was a problem hiding this comment.
Still waiting on CI, but looks OK.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #12157 +/- ##
==============================================
+ Coverage 83.13% 83.18% +0.04%
==============================================
Files 922 922
Lines 260821 260845 +24
==============================================
+ Hits 216826 216972 +146
+ Misses 43995 43873 -122
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23592 |
victorjulien
approved these changes
Nov 28, 2024
Member
|
Merged in #12188, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7324
Describe changes:
#12155 + additional commit to include fix that was done in big refactor and was needed to make SV tests pass
SV_BRANCH=OISF/suricata-verify#2144