Skip to content

next/651/70x/20241201/v1#12188

Merged
victorjulien merged 3 commits intoOISF:main-7.0.xfrom
victorjulien:next/651/70x/20241201/v1
Dec 2, 2024
Merged

next/651/70x/20241201/v1#12188
victorjulien merged 3 commits intoOISF:main-7.0.xfrom
victorjulien:next/651/70x/20241201/v1

Conversation

@victorjulien
Copy link
Member

satta and others added 3 commits December 1, 2024 07:49
Backport of commit 5d82521.

Ticket: 7323
instead of stopping on the first message if it does not
have a reason code, like conn and conn_ack

Was fixed in master by big refactor 0a1062f
@codecov
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.17%. Comparing base (c3a6abf) to head (1bae761).
Report is 3 commits behind head on main-7.0.x.

Additional details and impacted files
@@              Coverage Diff               @@
##           main-7.0.x   #12188      +/-   ##
==============================================
- Coverage       83.18%   83.17%   -0.01%     
==============================================
  Files             922      922              
  Lines          260821   260845      +24     
==============================================
+ Hits           216953   216966      +13     
- Misses          43868    43879      +11     
Flag Coverage Δ
fuzzcorpus 64.15% <84.61%> (+0.02%) ⬆️
suricata-verify 63.35% <100.00%> (+<0.01%) ⬆️
unittests 62.39% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23618

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@victorjulien victorjulien merged commit 1bae761 into OISF:main-7.0.x Dec 2, 2024
@victorjulien victorjulien mentioned this pull request Dec 2, 2024
@victorjulien victorjulien deleted the next/651/70x/20241201/v1 branch December 2, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants