Skip to content

Warnint 64to32 6186 v24.4#13159

Closed
catenacyber wants to merge 4 commits intoOISF:masterfrom
catenacyber:warnint-64to32-6186-v24.4
Closed

Warnint 64to32 6186 v24.4#13159
catenacyber wants to merge 4 commits intoOISF:masterfrom
catenacyber:warnint-64to32-6186-v24.4

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186

Describe changes:

  • fix some -Wshorten-64-to-32 warnings for remaining files : detect

#13026 with needed rebase and new warnings getting fixed

Still to do afterwards :

  • fix other detect warnings
  • CI check

@codecov
Copy link

codecov bot commented May 4, 2025

Codecov Report

Attention: Patch coverage is 95.18072% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.08%. Comparing base (4e2f1de) to head (1f87a74).
Report is 22 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13159   +/-   ##
=======================================
  Coverage   83.08%   83.08%           
=======================================
  Files         988      988           
  Lines      271850   271859    +9     
=======================================
+ Hits       225874   225887   +13     
+ Misses      45976    45972    -4     
Flag Coverage Δ
fuzzcorpus 61.44% <83.13%> (+0.01%) ⬆️
livemode 18.95% <12.04%> (+<0.01%) ⬆️
pcap 44.81% <73.49%> (+0.01%) ⬆️
suricata-verify 64.82% <90.36%> (-0.01%) ⬇️
unittests 58.20% <66.26%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 25985

@victorjulien victorjulien added this to the 8.0 milestone May 7, 2025
@victorjulien
Copy link
Member

Merged in #13179, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants