Merged
Conversation
Ticket: 7665 Instead of each keyword calling DetectSetupDirection, use a new flag SIGMATCH_SUPPORT_DIR so that DetectSetupDirection gets called, before parsing the rest of the keyword. Allows to support filesize keyword in transactional signatures
Ticket: 6186 Fixes d674ce2 ("app/ftp: Use Rust FTP response line handling")
Ticket: 6186
so that future lua code can specify a direction
Since hooks, we do not need a specific SMTP buffer list id.
Ticket: 7605
Refactor ftp.command handling to use helper functions from detect-engine-helper.[ch] for reduced code duplication.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13179 +/- ##
========================================
Coverage 83.07% 83.08%
========================================
Files 988 988
Lines 272125 272256 +131
========================================
+ Hits 226062 226194 +132
+ Misses 46063 46062 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jufajardini
approved these changes
May 7, 2025
jasonish
approved these changes
May 7, 2025
|
Information: QA ran without warnings. Pipeline 26012 |
This was referenced May 7, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#2493