detect/ftp: Use helper functions with ftp.command#13171
Closed
jlucovsky wants to merge 1 commit intoOISF:masterfrom
Closed
detect/ftp: Use helper functions with ftp.command#13171jlucovsky wants to merge 1 commit intoOISF:masterfrom
jlucovsky wants to merge 1 commit intoOISF:masterfrom
Conversation
Refactor ftp.command handling to use helper functions from detect-engine-helper.[ch] for reduced code duplication.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13171 +/- ##
==========================================
- Coverage 83.08% 83.07% -0.02%
==========================================
Files 988 988
Lines 271850 272123 +273
==========================================
+ Hits 225874 226064 +190
- Misses 45976 46059 +83
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
WARNING:
Pipeline 26007 |
victorjulien
approved these changes
May 7, 2025
Merged
Member
|
Merged in #13179, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #13164
Refactor ftp.command handling to use helper functions from detect-engine-helper.[ch] for reduced code duplication.
Describe changes:
Updates:
BUFFER_DESCinstead ofBUFFER_NAME(see detect/ftp: Use helper functions with ftp.command #13164)Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=