rust: update msrv to 1.85 #15060
Conversation
Don't install extra repo's in the script, do it in CI. These are covered by the documentation as they vary depending on the version and variant.
Debian 13 ships Rust 1.85 by default, Ubuntu requires installing a specific patch to get newer then 1.75. So to support a newer MSRV, these operating systems need different examples.
1.85 was chosen for now as it supports edition 2024. However, we have not set our edition to 2024 yet.
Disable the clippy warning for not using modern C string literals. Ubuntu 24.04 still ships cbindgen 0.26.0 that doesn't support these, so migrating to modern C string literals would require Ubuntu 24.04 users wishing to build from git to install cbindgen with cargo.
To pick up a newer version of Rust.
|
WARNING:
Pipeline = 30375 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15060 +/- ##
==========================================
- Coverage 82.59% 82.57% -0.02%
==========================================
Files 990 990
Lines 271761 271761
==========================================
- Hits 224465 224420 -45
- Misses 47296 47341 +45
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| - run: make -j ${{ env.CPUS }} | ||
| - run: ./src/suricata --build-info # check if we can run Suricata | ||
|
|
||
| debian-13-minimal-recommended-build: |
There was a problem hiding this comment.
I wonder if we could remove some builders because they do not bring any value...
There was a problem hiding this comment.
I wonder if we could remove some builders because they do not bring any value...
Yeah, probably. Killed one off a couple weeks ago as its just required a few lines added to another similar build. Probably many more like this.
But this one tests documentation as well for a popular distro, so some are hard to get rid off, even if they don't do much different than another build.
There was a problem hiding this comment.
That was a general idea, not criticizing this PR
| libjansson-dev \ | ||
| libevent-dev \ | ||
| libevent-pthreads-2.1-7 \ | ||
| libpython2.7 \ |
There was a problem hiding this comment.
Should we remove all these obsolete libpython2 ?
catenacyber
left a comment
catenacyber
left a comment
There was a problem hiding this comment.
Looks good but...
Looks like this first needs changes on QA side
ERROR: Rust 1.85.0 or newer required.
Rust version 1.75.0 was found.
Please don't set this changes requested state if there is nothing to change. Now we need a new PR to clear the state. A baseline update has a label, so it should not lead to a "changes requested" state. |
|
Replaced by #15111 |
5 participants
We are suppressing a clippy warning as Rust 1.85 has C string literals. However
the cbindgen availabe with apt on Ubuntu 24.04 does not support these. C string
literals are a handy construct for us, but can be left til later.
Not a draft, but consider a preview of whats needed to support Rust 1.85,
hopefully in the near future.
Previous PR: #15034